Skip to content

Conversation

@HennerM
Copy link
Collaborator

@HennerM HennerM commented Jan 25, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jan 25, 2018

Coverage Status

Coverage increased (+0.3%) to 87.244% when pulling b7334f7 on remove-relationship into 8b4acbf on master.

@safo6m safo6m self-requested a review June 5, 2018 23:48
@safo6m
Copy link
Collaborator

safo6m commented Jun 5, 2018

What is the logic behind this one?
What is a use case when the lib would have to take care of deleting relationships?

If I understood correctly, you want to delete one relationship from a model. In that case a better solution would be deleting the relationship model itself.

@RicardoNeves
Copy link
Contributor

@safo6m
I might be wrong but this might be related with the following issue.
Let's say you have a tree structure of nodes. Each node can have a parent node and can have multiple children nodes.
Let's say you have a "node A" that is the parent of "node B".
How do you remove the parent relationship from "node B"?

I didn't had time to test this branch yet, but I'm having this kind of issue in one of my projects right now.

@frans-beech-it
Copy link
Contributor

Would be great if this could get in 😃

Removing existing relations is currently not possible and that's a real missing feature

@jevanlingen
Copy link

PR is not complete (anymore). I added the changes to my project, so I could make use of this feature. I needed to check if the relationshipModel did exist in the updateRelationships function as well (line 436).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants